Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KV Scan - paginate with exponential jumps #8002

Merged
merged 1 commit into from
Jul 25, 2024
Merged

KV Scan - paginate with exponential jumps #8002

merged 1 commit into from
Jul 25, 2024

Conversation

guy-har
Copy link
Contributor

@guy-har guy-har commented Jul 24, 2024 •
edited
Loading

No description provided.

@guy-har guy-har requested a review from itaiad200 July 24, 2024 10:42
@guy-har guy-har added the include-changelog PR description should be included in next release changelog label Jul 24, 2024
@github-actions GitHub Actions
Copy link

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed

itaiad200
itaiad200 approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@itaiad200 itaiad200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Let me test it tomorrow before you merge it

@guy-har guy-har linked an issue Jul 25, 2024 that may be closed by this pull request
KV store optimization: Exponential Backoff for Pagination #8005
Closed
@guy-har guy-har force-pushed the feature/exponential-scan-paging branch from c9f8445 to 446f9c7 Compare July 25, 2024 10:46
itaiad200
itaiad200 approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@itaiad200 itaiad200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked with lakeFS with 50K object writes, it works

@guy-har guy-har force-pushed the feature/exponential-scan-paging branch from 446f9c7 to 6871d7f Compare July 25, 2024 11:04
@guy-har guy-har marked this pull request as ready for review July 25, 2024 11:05
@guy-har guy-har merged commit 62803f8 into master Jul 25, 2024
35 checks passed
@guy-har guy-har deleted the feature/exponential-scan-paging branch July 25, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itaiad200 itaiad200 itaiad200 approved these changes

Assignees
No one assigned
Labels
include-changelog PR description should be included in next release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KV store optimization: Exponential Backoff for Pagination
2 participants
@guy-har @itaiad200