Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create db lua 7970 #8000

Merged
merged 27 commits into from
Aug 7, 2024
Merged

create db lua 7970 #8000

merged 27 commits into from
Aug 7, 2024

Conversation

nadavsteindler
Copy link
Contributor

@nadavsteindler nadavsteindler commented Jul 18, 2024 •
edited
Loading

closes #7970

@github-actions GitHub Actions
Copy link

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed

@nadavsteindler nadavsteindler marked this pull request as draft July 18, 2024 11:11
@nadavsteindler nadavsteindler added the include-changelog PR description should be included in next release changelog label Jul 18, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 28, 2024 •
edited
Loading

♻️ PR Preview d4b04e2 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

Isan-Rivkin
Isan-Rivkin previously requested changes Jul 31, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 1, 2024

E2E Test Results - Quickstart

10 passed

@nadavsteindler nadavsteindler dismissed Isan-Rivkin’s stale review August 4, 2024 10:47

I made the equivalent change together with the other changes that were requested

Isan-Rivkin
Isan-Rivkin requested changes Aug 5, 2024
View reviewed changes
nadavsteindler and others added 2 commits August 5, 2024 17:35
@nadavsteindler @Isan-Rivkin
Apply suggestions from code review
ef23e86 
Co-authored-by: isan_rivkin <isanrivkin@gmail.com>
@nadavsteindler
table not json
094fbb4
Isan-Rivkin
Isan-Rivkin previously requested changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@Isan-Rivkin Isan-Rivkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing all the issues, couple of changes

@nadavsteindler @Isan-Rivkin
Apply suggestions from code review
3577733 
Co-authored-by: isan_rivkin <isanrivkin@gmail.com>
@nadavsteindler nadavsteindler dismissed Isan-Rivkin’s stale review August 7, 2024 08:16

Made changes separately

Isan-Rivkin
Isan-Rivkin approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@Isan-Rivkin Isan-Rivkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! THANK YOU!

@nadavsteindler nadavsteindler merged commit 1e1d2f5 into master Aug 7, 2024
37 checks passed
@nadavsteindler nadavsteindler deleted the glue_db7970 branch August 7, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielshaqed arielshaqed arielshaqed left review comments

@Isan-Rivkin Isan-Rivkin Isan-Rivkin approved these changes

@guy-har guy-har Awaiting requested review from guy-har

Assignees
No one assigned
Labels
include-changelog PR description should be included in next release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow Glue exporter to create a database per branch
3 participants
@nadavsteindler @arielshaqed @Isan-Rivkin