useEffect hook missing dep on logged in user

treeverse · Apr 8, 2024 · 848ce50 · 848ce50
1 parent e7ed5d0
commit 848ce50
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/webui/src/lib/hooks/storageConfig.tsx b/webui/src/lib/hooks/storageConfig.tsx
@@ -7,6 +7,7 @@ import React, {
 } from "react";
 
 import { config } from "../api";
+import useUser from "./user";
 
 type StorageConfigContextType = {
   error: Error | null;
@@ -54,6 +55,7 @@ export const useStorageConfig = () => {
 export const StorageConfigProvider: FC<{ children: React.ReactNode }> = ({
   children,
 }) => {
+  const { user } = useUser();
   const [storageConfig, setStorageConfig] = useState<StorageConfigContextType>(
     storageConfigInitialState
   );
@@ -67,7 +69,7 @@ export const StorageConfigProvider: FC<{ children: React.ReactNode }> = ({
       });
     };
     fetchStorageConfigAndSetState();
-  }, []);
+  }, [user]);
 
   return (
     <StorageConfigContext.Provider value={storageConfig}>

diff --git a/webui/test/e2e/common/viewParquetObject.spec.ts b/webui/test/e2e/common/viewParquetObject.spec.ts
@@ -21,6 +21,6 @@ test.describe("Object Viewer - Parquet File", () => {
         const repositoryPage = new RepositoryPage(page);
         await repositoryPage.clickObject(PARQUET_OBJECT_NAME);
         await expect(page.getByText("Loading...")).not.toBeVisible();
-    })
+    });
 })