Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using different TamaGo version for recovery image #298

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

AlCutter
Copy link
Collaborator

Armory-UMS is not currently compatible with 1.23.1, so allow the TamaGo version for building the recovery image to be separately specified for now, and provide a known working default.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@46b3c20). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff           @@
##             main    #298   +/-   ##
======================================
  Coverage        ?   2.22%           
======================================
  Files           ?      21           
  Lines           ?    1575           
  Branches        ?       0           
======================================
  Hits            ?      35           
  Misses          ?    1529           
  Partials        ?      11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlCutter
Copy link
Collaborator Author

I've applied these changes to the presubmit live env, which fixed the build issue in transparency-dev/armored-witness-boot#138.

Will push to the ci and prod envs when approved.

@AlCutter AlCutter merged commit dc7f089 into transparency-dev:main Oct 16, 2024
6 checks passed
@AlCutter AlCutter deleted the fix_recovery_build branch October 16, 2024 13:21
@AlCutter
Copy link
Collaborator Author

Pushed to ci and prod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants