bugfix: impl: require at least one of the source ref/sha extensions #109
+126
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like with Trusted Publishing we need at least one of these, but not necessarily both. We need to gracefully handle the scenario where at least one (both not both) is missing. xref SWIFTSIM/swiftgalaxy#26 Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
facutuesca
approved these changes
Apr 3, 2025
woodruffw
added a commit
to trail-of-forks/warehouse
that referenced
this pull request
Apr 4, 2025
See trailofbits/pypi-attestations#109. See SWIFTSIM/swiftgalaxy#26. Signed-off-by: William Woodruff <william@trailofbits.com>
di
pushed a commit
to pypi/warehouse
that referenced
this pull request
Apr 4, 2025
See trailofbits/pypi-attestations#109. See SWIFTSIM/swiftgalaxy#26. Signed-off-by: William Woodruff <william@trailofbits.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like with Trusted Publishing we need at least one of these, but not necessarily both. We need to gracefully handle the scenario where at least one (both not both) is missing.
xref SWIFTSIM/swiftgalaxy#26
CC @di