Merge pull request #13 from tpgillam/tg/stuff

Fix CI, small tweaks

.github/workflows/ci.yml

@@ -1,5 +1,12 @@
 name: CI
-on: [push, pull_request]
+# Run on main, tags, or any pull request
+on:
+  schedule:
+    - cron: '0 2 * * *'  # Daily at 2 AM UTC (8 PM CST)
+  push:
+    branches: [main]
+    tags: ["*"]
+  pull_request:
 jobs:
   test:
     name: Julia ${{ matrix.version }} - ${{ matrix.os }} - ${{ matrix.arch }} - ${{ github.event_name }}
@@ -9,8 +16,8 @@ jobs:
       matrix:
         version:
           - '1.5'
-          - '1.6'
-          - '1.7-nightly'
+          - '1'
+          - 'nightly'
         os:
           - ubuntu-latest
         arch:

Project.toml

@@ -1,7 +1,7 @@
 name = "AssociativeWindowAggregation"
 uuid = "444271a7-5434-4a02-b82b-0e30a9223c60"
 authors = ["Thomas Gillam <tpgillam@googlemail.com>"]
-version = "0.3.1"
+version = "0.3.2"
 
 [deps]
 DataStructures = "864edb3b-99cc-5e75-8d2d-829cb0a9cfe8"

src/base.jl

@@ -137,16 +137,16 @@ Base.@propagate_inbounds function update_state!(
         empty!(state.previous_cumsum)
         upper = length(state.values)
         lower = 1 + num_values_to_remove
-        if (upper - lower) >= 0  # i.e. we have a non-zero range
+        @inbounds if (upper - lower) >= 0  # i.e. we have a non-zero range
             i = upper
-            accumulation = @inbounds(state.values[i])
+            accumulation = state.values[i]
             while true
                 push!(state.previous_cumsum, accumulation)
                 i -= 1
                 i >= lower || break
                 # If we were to use a mutating operation here, then we'd have to introduce
                 # a copy above. So there is no drawback to using the non-mutating Op.
-                accumulation = Op(@inbounds(state.values[i]), accumulation)
+                accumulation = Op(state.values[i], accumulation)
             end
         end
 

src/time.jl

@@ -41,7 +41,7 @@ mutable struct TimeWindowAssociativeOp{Value,Op,Op!,Time,TimeDiff}
             throw(ArgumentError("Got window $window, but it must be positive."))
         end
         return new{Value,Op,Op!,Time,TimeDiff}(
-            WindowedAssociativeOp{Value,Op,Op!,}(), window, Deque{Time}(), false
+            WindowedAssociativeOp{Value,Op,Op!}(), window, Deque{Time}(), false
         )
     end
 end