replace event emitter with typed emitter

torusresearch · Aug 21, 2024 · 939ef79 · 939ef79
1 parent 0fe133a
commit 939ef79
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 5 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -56,6 +56,7 @@
     "lint-staged": "^15.2.8",
     "prettier": "^3.3.3",
     "rimraf": "^6.0.1",
+    "typed-emitter": "^2.1.0",
     "typescript": "^5.5.4"
   },
   "author": "Torus Labs",

diff --git a/src/utils/PopupHandler.ts b/src/utils/PopupHandler.ts
@@ -1,12 +1,13 @@
-import { EventEmitter } from "eventemitter3";
+import { EventEmitter } from "events";
+import type { default as TypedEmitter } from "typed-emitter";
 
 import { getPopupFeatures } from "./helpers";
 
-export interface PopupHandlerEvents {
-  close: void;
-}
+export type PopupHandlerEvents = {
+  close: () => void;
+};
 
-class PopupHandler extends EventEmitter<PopupHandlerEvents> {
+class PopupHandler extends (EventEmitter as new () => TypedEmitter<PopupHandlerEvents>) {
   url: URL;
 
   target: string;
@@ -22,6 +23,7 @@ class PopupHandler extends EventEmitter<PopupHandlerEvents> {
   timeout: number;
 
   constructor({ url, target, features, timeout = 30000 }: { url: URL; target?: string; features?: string; timeout?: number }) {
+    // eslint-disable-next-line constructor-super
     super();
     this.url = url;
     this.target = target || "_blank";