Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recent VVV has new paths - breaks dashboard functionality #50

Open
pjv opened this issue Feb 15, 2017 · 5 comments
Open

recent VVV has new paths - breaks dashboard functionality #50

pjv opened this issue Feb 15, 2017 · 5 comments

Comments

@pjv
Copy link

pjv commented Feb 15, 2017

I just set up a new VVV install based on VVV 1.4.1 and the configuration has changed some paths which makes the dashboard not work quite right (dashboard not finding things like the wp-config.php and etc.).

I had to adjust the paths in dashboard/vvv_dash/hosts/defaults.php like so (note addition of public_html):

'wordpress-default' => array(
	'hostname'        => 'wordpress-default',
	'domain'          => 'local.wordpress.dev',
	'web_root'        => '/srv/www',
	'host_path'       => '/srv/www/wordpress-default',
	'public_dir'      => 'public_html',
	'wp_path'         => '/srv/www/wordpress-default/public_html',
	'wp_content_path' => '/srv/www/wordpress-default/public_html/wp-content',
	'composer_path'   => '',
	'wp_config_path'  => '/srv/www/wordpress-default/public_html/wp-config.php',
	'env_path'        => '',
	'debug_log'       => '',
	'wp_is_installed' => 'true',
	'is_wp_site'      => 'true',
),
@Mte90
Copy link
Contributor

Mte90 commented Mar 14, 2017

pretty annoying :-/

@topdown
Copy link
Owner

topdown commented Mar 14, 2017

I know this needs to be fixed. I will try to put aside some time to fix it.

The reality is that I don't update VVV unless there is a good reason to because I have had issues of VVV breaking after updates in the past. Which means my dev environment is either down until fixed or I don't update.

Like most using VVV, I do this for a living and having my dev environment broke while in the middle of projects is not an option. That is the reason for the delay in a fix. Sorry!

topdown added a commit that referenced this issue Mar 14, 2017
@topdown
Copy link
Owner

topdown commented Aug 8, 2017

I merged in the changes that @swashata made in the PR. Could you all do a pull on the dashboard and verify its working properly for you now.
NOTE: you need to copy the newly changed dashboard-custom.php to the default root overwriting the old one or make the changes from the PR which is just an addition to the paths. See #52

@swashata
Copy link
Contributor

swashata commented Aug 8, 2017

@topdown I didn't think I needed to looked into this. I did not make any changes to the public_dir var, nor did I think it was needed. It works fine from my end.

@tomjn
Copy link

tomjn commented Feb 28, 2018

Note that all these defaults changed, the correct approach is to use a YAML parser to parse the sites section of vvv-custom.yml. See the default dashboard for an example on how to do this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants