Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Github ticket rules #16

Open
callmekatootie opened this issue Jul 11, 2020 · 3 comments
Open

Github ticket rules #16

callmekatootie opened this issue Jul 11, 2020 · 3 comments

Comments

@callmekatootie
Copy link
Collaborator

callmekatootie commented Jul 11, 2020

How to work with git tickets

The basic flow for handling a ticket is as follows:

  1. Assign the ticket to yourself, change the label to "tcx_Assigned", remove the "tcx_OpenForPickup" label. Please only assign tickets to yourself when you are ready to work on it. I don't want tickets assigned to someone and then not have them work on a ticket for 24 hours. The goal here is a quick turnaround for the client. If you can't work on a ticket immediately, leave it for someone else. If there is no update on a ticket for more than 6 hours after assignment, you could be unassigned

  2. Complete the ticket and create a merge request. Please ensure your merge request can be merged automatically and that it's against the latest commit in Git when you create it. NO HOARDING OF TICKETS. If you are picking a ticket up, you are expected to work on it at that moment. You can also take couple of hours (1-2) more before you start working on it but if the time that you are taking to provide a solution is not proportional to the effort estimated for that ticket, then you will be unassigned without warning. If you need more time, please comment on the ticket - to indicate that you are actively working on it.

  3. Change the label on the ticket to "tcx_ReadyForReview"

After seeing a ticket marked as "tcx_ReadyForReview", the copilot will review that ticket, usually within 24 hours.

Note that you are expected to keep your changes in-sync with Git - make sure to do a pull before you push changes to make sure there aren't any merge issues.

Accepted fix

If a fix is accepted, a payment ticket will be created on the Topcoder platform within 5-10 minutes of the issue being closed. You should see the payment in your PACTs within 24 hours.

Rejected fix

If a fix is rejected, a comment, and possibly a screenshot, will be added to the ticket explaining why the fix was rejected. The status will be changed to "tcx_Feedback".

If a fix is rejected, that ticket is your priority. You should not assign yourself any more tickets until you complete the required additional fixes!

Payment amounts

Each ticket in Github has a dollar value. That is the amount you will be paid when the ticket is completed, merged, and verified by the copilot. Note that there is still a 30 day waiting period as the payment will be treated as a regular TopCoder challenge payment.

Important Rules:

  • You can assign any unassigned issue to yourself with an "Open for pick up" label (first come first serve)

  • You can only assign ONE AT A TIME. The nature of it being assigned will indicate it is not available to anyone else.

  • You will fix the ticket by committing changes to the master branch.

  • After marking a ticket "tcx_ReadyForReview" you are eligible to accept another. You do NOT need to wait for the copilot to validate your fix.

  • You can do as many tickets as you want, as long as you follow the rules above.

  • If an assigned task is not done in 24 hours, you will need to explain why it is not completed as a comment on the ticket.

  • You can ask questions directly on the Github ticket.

ANYONE NOT FOLLOWING THE RULES ABOVE WILL BE WARNED AND POTENTIALLY LOSE THEIR GITHUB ACCESS!

@callmekatootie callmekatootie pinned this issue Jul 17, 2020
@Vips19 Vips19 unpinned this issue Jul 23, 2020
@callmekatootie callmekatootie pinned this issue Jul 23, 2020
@callmekatootie
Copy link
Collaborator Author

@topcoder-platform/u-bahn-members Kindly note that even though I may accept the Pull Request, there will be a delay in marking the ticket as completed - I need to still verify the changes made in IE11 browser, for which I need to push the changes to our deployed instance (https://skill-search.topcoder-dev.com/) and test on another device.

Hence, even though I may accept the PR, the ticket will not be closed until I verify that the changes work in IE11 too

@phongnt phongnt unpinned this issue Jul 23, 2020
@callmekatootie callmekatootie pinned this issue Jul 23, 2020
@phongnt phongnt unpinned this issue Jul 24, 2020
@callmekatootie
Copy link
Collaborator Author

@phongnt Kindly do not unpin this - it is intentionally pinned for all.

@callmekatootie
Copy link
Collaborator Author

@topcoder-platform/u-bahn-members Kindly do not forget to update your base branch to keep it in sync with develop branch - Lots of updates being merged - you will soon run into merge conflicts if you are not working on the latest code base...

@Giri-Suman Giri-Suman unpinned this issue Jul 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant