fix multiply with overflow error in i686-msvc-windows environment #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3 +/- ##
=======================================
Coverage 94.29% 94.29%
=======================================
Files 5 5
Lines 1034 1034
=======================================
Hits 975 975
Misses 59 59 ☔ View full report in Codecov by Sentry. |
|
Thanks. I'll follow up an make it a |
|
You can find this fix in 0.7.1: https://crates.io/crates/fastbloom/0.7.1 |
samuelgja
added a commit
to samuelgja/fastbloom
that referenced
this pull request
Sep 10, 2024
- Update dependencies in Cargo.toml - Add serde support to bit_vector.rs and hasher.rs - Implement serialization traits for BlockedBitVec and BloomFilter structs - Add ArchivedBlockedBitVec and ArchivedBloomFilter structs for archived serialization Closes tomtomwombat#3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an integer overflow issue that occurs in the i686-msvc-windows environment. The problem arises in the block_index function due to the calculation expression ((hash >> 32) as usize * num_blocks) >> 32.
In a 32-bit environment, the usize type is 32 bits in size and can represent values up to 2^32 - 1. However, this calculation expression may result in a value that exceeds the representation range of the usize type, causing an overflow error.