Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds location check by classloader, adds spotless for google-java-format, adds lat/long search for city #20

Merged
merged 5 commits into from
Aug 10, 2024

Conversation

jottinger
Copy link
Contributor

No description provided.

2. Add check for location4j.bin such that it's from the same classloader as the default loader
3. Add lat/long search for city

Closes #17
Closes #18
Closes #19
Copy link
Owner

@tomaytotomato tomaytotomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jottinger for this awesome PR.

Just a minor issue with maven pom.xml having a duplicate modules tag.

Also please update the readme with your new functionality you added, thanks

pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
@tomaytotomato tomaytotomato merged commit 5e9bb6f into tomaytotomato:master Aug 10, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants