Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] use .bin for location4j data instead of the json #9

Closed
jottinger opened this issue Aug 9, 2024 · 1 comment · Fixed by #10
Closed

[IMPROVEMENT] use .bin for location4j data instead of the json #9

jottinger opened this issue Aug 9, 2024 · 1 comment · Fixed by #10

Comments

@jottinger
Copy link
Contributor

jottinger commented Aug 9, 2024

Summary
The source tree has a binary-encoded version of the data (created via java serialization, which may or may not be the best choice, but that's a separate concern). The artifact for 1.0.0 (the only one available) has the JSON file in text form.

  1. The artifact should have the .bin instead, OR the JSON should be compressed in the artifact.
  2. If fix number 1 is applied (with the .bin, not compression), the resource file should be loaded canonically (i.e., always from the jar and not from "any file with the right name in the classpath" - otherwise Java serialization issues MAY rear their ugly heads.
@tomaytotomato
Copy link
Owner

I just merged this here - #6

I am going to do another release soon with the location4j.bin and no more JSON or Jackson dependency

There was some improvements from this listed in the PR.

I will create an issue for point #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants