Added possibility to create containers during import if they are not found (controlled by config file)

Author: tomaskir

README.md

@@ -12,7 +12,7 @@ These should be places in the working directory of the application (same directo
 More on the configuration files in the next section.
 
 After downloading the .jar and creating the configuration files, you can run the importer using:
-> java -jar netxms-csv-importer.1.0.1.jar
+> java -jar netxms-csv-importer.1.1.0.jar
 
 ## Configuration files
 

examples/config.properties

@@ -7,3 +7,6 @@ netxms.address=netxms.server.local
 netxms.port=4701
 netxms.username=admin
 netxms.password=netxms
+
+# import configuration
+import.create.containers=false

src/main/java/com/github/tomaskir/netxms/csvimporter/Application.java

@@ -16,6 +16,7 @@ public final class Application {
     private static final String NXMS_PORT_PROPERTY = "netxms.port";
     private static final String NXMS_USERNAME_PROPERTY = "netxms.username";
     private static final String NXMS_PASSWORD_PROPERTY = "netxms.password";
+    private static final String IMPORT_CREATE_CONTAINERS_PROPERTY = "import.create.containers";
 
     public static void main(String[] args) {
         Properties properties;
@@ -35,7 +36,7 @@ public static void main(String[] args) {
                     properties.getProperty(NXMS_USERNAME_PROPERTY), properties.getProperty(NXMS_PASSWORD_PROPERTY));
 
             System.out.println("Creating nodes on the NetXMS server.");
-            NetxmsConnector.getInstance().addNodes(nodeList);
+            NetxmsConnector.getInstance().addNodes(nodeList, Boolean.parseBoolean(properties.getProperty(IMPORT_CREATE_CONTAINERS_PROPERTY)));
         } catch (Exception e) {
             System.out.println("Error: " + e.getClass().getSimpleName() + " - " + e.getMessage() + ".");
             return;

src/main/java/com/github/tomaskir/netxms/csvimporter/netxms/NetxmsConnector.java

@@ -9,14 +9,17 @@
 import org.netxms.client.NXCSession;
 import org.netxms.client.ObjectFilter;
 import org.netxms.client.objects.AbstractObject;
+import org.netxms.client.objects.Node;
 
 import java.io.IOException;
 import java.util.List;
 
 @NoArgsConstructor(access = AccessLevel.PRIVATE)
 public final class NetxmsConnector {
     @Getter
-    private final static NetxmsConnector instance = new NetxmsConnector();
+    private static final NetxmsConnector instance = new NetxmsConnector();
+
+    private static final int INFRASTRUCTURE_SERVICES_ID = 2;
 
     private NXCSession nxcSession;
 
@@ -27,8 +30,10 @@ public void connect(String address, String port, String username, String passwor
         nxcSession.syncObjects();
     }
 
-    public void addNodes(List<CsvNode> nodeList) throws IOException, NXCException {
+    public void addNodes(List<CsvNode> nodeList, boolean createContainers) throws IOException, NXCException {
         ObjectFilter filter;
+        NXCObjectCreationData objectCreationData;
+        long nodeParentId;
 
         for (final CsvNode node : nodeList) {
             System.out.print(".");
@@ -42,9 +47,10 @@ public boolean filter(AbstractObject object) {
                 }
             };
 
+            AbstractObject object = nxcSession.findObject(filter);
             if (object != null) {
                 System.out.println();
-                System.out.println("Warning - object with name '" + node.getName() + "' already exists, not creating the node.");
+                System.out.println("Warning - object with name '" + node.getName() + "' or address '" + node.getAddress() + "' already exists, not creating the node.");
                 continue;
             }
 
@@ -59,13 +65,24 @@ public boolean filter(AbstractObject object) {
             // find node's container
             AbstractObject container = nxcSession.findObject(filter);
             if (container == null) {
-                System.out.println();
-                System.out.println("Warning - container '" + node.getContainer() + "' not found for node '" + node.getName() + "', not creating node.");
-                continue;
+                // if not found, behaviour determined by "import.create.containers" config property
+                if (!createContainers) {
+                    // log warning
+                    System.out.println();
+                    System.out.println("Warning - container '" + node.getContainer() + "' not found for node '" + node.getName() + "', not creating node.");
+                    continue;
+                } else {
+                    // create container
+                    objectCreationData = new NXCObjectCreationData(AbstractObject.OBJECT_CONTAINER, node.getContainer(), INFRASTRUCTURE_SERVICES_ID);
+                    nodeParentId = nxcSession.createObject(objectCreationData);
+                }
+            } else {
+                // if found, use it as node's parent
+                nodeParentId = container.getObjectId();
             }
 
             // object creation data
-            NXCObjectCreationData objectCreationData = new NXCObjectCreationData(AbstractObject.OBJECT_NODE, node.getName(), container.getObjectId());
+            objectCreationData = new NXCObjectCreationData(AbstractObject.OBJECT_NODE, node.getName(), nodeParentId);
             objectCreationData.setPrimaryName(node.getAddress());
 
             // create the object