View #8
View #8
Conversation
There was a problem hiding this comment.
Hi @tomasesquivelgc,
Required Changes ♻️
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
- No linter errors ✔️
- Good UI ✔️
- Descriptive PR ✔️
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
You can also consider using the gem 'faker', '~> 2.18', '>= 2.18.0' in your seeds, like this 👇🏽
require 'faker'
# Create 10 users
10.times do
User.create!(
name: Faker::Name.name,
photo: Faker::Avatar.image,
bio: Faker::Lorem.paragraph,
post_counter: Faker::Number.number(digits: 2),
)
end
# Create 50 posts
50.times do
author_id = User.pluck(:id).sample # Obtiene un ID de usuario existente al azar
Post.create!(
title: Faker::Lorem.sentence,
text: Faker::Lorem.paragraph,
comments_counter: Faker::Number.number(digits: 2),
likes_counter: Faker::Number.number(digits: 2),
author_id: author_id,
)
end
# Create 100 comments
1000.times do
user_id = User.pluck(:id).sample # Obtiene un ID de usuario existente al azar
post_id = Post.pluck(:id).sample # Obtiene un ID de post existente al azar
Comment.create!(
text: Faker::Lorem.paragraph,
user_id: user_id,
post_id: post_id,
)
endCheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
app/controllers/posts_controller.rb
Outdated
| def index; end | ||
| def index | ||
| @user = User.find(params[:user_id]) | ||
| @use_posts = @user.recent_posts |
There was a problem hiding this comment.
- Please 🙏🏽 correct this line in your controller to avoid errors in your view. It should be
@user_posts👇🏽
- When I opened the user#show page it should show just three posts, but it shows all of them instead. Please correct the
recent_postmethod and check that it shows just three posts.
There was a problem hiding this comment.
Hi @tomasesquivelgc,
Required Changes ♻️
Great work on making the changes requested by a previous reviewer 👏
You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.
Highlights
- Correct use of partials ✔️
- Correct methods ✔️
- Good UI ✔️
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
app/controllers/users_controller.rb
Outdated
| def show; end | ||
| def show | ||
| @user = User.find(params[:id]) | ||
| @posts = @user.posts |
There was a problem hiding this comment.
- In the last review I also suggested reviewing the recent_posts method because it should show only three posts in user#show page, but it is showing all of them. Please 🙏🏽 fix this error by replacing posts with the correct method in this line 👇🏽
@posts = @user.recent_posts
There was a problem hiding this comment.
Hi @tomasesquivelgc 👏 👏 👏 👏,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Highlights
Implemented recent_post method in user_show page ✔️
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| <a href="<%= user_post_path(user, post) %>" class="info-card"> | ||
| <h4 class="user-post-title"><%= post.title %></h4> | ||
| </br> | ||
| <p class="user-post-text"><%= post.text %></p> |
There was a problem hiding this comment.
- [Optional] Kindly ensure that all the post (not recent_posts) are rendered in the post_index page.
| <div class="comments-card info-card"> | ||
| <% post.recent_comments.reverse.each do |comment| %> | ||
| <p><%= comment.user.name %>: <%= comment.text %></p> |
There was a problem hiding this comment.
- [Optional] Kindly ensure that all the comments (not recent_comments) are rendered in the post_show page.
In this branch I: