Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macros: make select! budget-aware #7164

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

macros: make select! budget-aware #7164

wants to merge 2 commits into from

Conversation

maminrayej
Copy link
Member

Resolves #7108.

@maminrayej maminrayej added A-tokio Area: The main tokio crate M-macros Module: macros in the main Tokio crate labels Feb 17, 2025
@maminrayej maminrayej requested a review from Darksonn February 17, 2025 16:12
@Darksonn Darksonn added the M-coop Module: tokio/coop label Feb 17, 2025
@maminrayej
Copy link
Member Author

Previously the test would hang on the master branch. Although this indicates a failure of some sort, it's undesirable for a test to hang. The test is improved to immediately fail if select! does not respect the budget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Awaiting requested review from Darksonn

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate M-coop Module: tokio/coop M-macros Module: macros in the main Tokio crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MPSC queue hangs on repeated polling
2 participants
@maminrayej @Darksonn