Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve title bar in direct messages #66

Merged
merged 8 commits into from
Jan 10, 2025
Merged

Conversation

jrichardsen
Copy link
Collaborator

In direct messages, show the room title (i.e., the username) in the color of the user's status. Also, show the user's status text in parentheses.

Fixes #35

In direct messages, show the room title (i.e., the username) in the
color of the user's status. Also, show the user's status text in
parentheses.

Fixes #35

Signed-off-by: jrichardsen <jrichardsen@emlix.com>
@jrichardsen jrichardsen requested a review from tofubert January 9, 2025 13:17
@jrichardsen jrichardsen self-assigned this Jan 9, 2025
Signed-off-by: jrichardsen <jrichardsen@emlix.com>
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 85.91549% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/ui/widget/title_bar.rs 87.1% 9 Missing ⚠️
src/ui/app.rs 0.0% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/backend/nc_request/nc_req_data_user.rs 0.0% <ø> (ø)
src/ui/app.rs 0.0% <0.0%> (ø)
src/ui/widget/title_bar.rs 92.2% <87.1%> (-1.1%) ⬇️

... and 1 file with indirect coverage changes

Signed-off-by: jrichardsen <jrichardsen@emlix.com>
Signed-off-by: jrichardsen <jrichardsen@emlix.com>
Signed-off-by: jrichardsen <jrichardsen@emlix.com>
src/ui/widget/title_bar.rs Outdated Show resolved Hide resolved
@tofubert tofubert merged commit 30f4d6b into main Jan 10, 2025
7 checks passed
@tofubert tofubert deleted the feature/better_dm_titlebar branch January 10, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show Status Texts of People
2 participants