-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FR] contol volume with volume buttons #93
Comments
hi, just implemented your feature request. If the volume buttons are pressed on the main activity, the volume will be increased or decreased depending on the button for all active players. If the buttons are pressed on the activity for a certain player, the volume will be changed only for that player. You can test it, building the branch feat/issue93 or installing the attached debug.apk |
wow, thanks a lot.
I just tested and see it works when the app is active.
But when the app isn't active (in background) the volume buttons don't
work. I'm on Android 13 just in case.
|
Yes, your right the current solution is only working if the activity is active. I don't have a clue how to implement it for the background case. In that case other audio streams might be playing and so it's not clear for me how to decide that the push on a volume key is because the user wants to change the volume of Yaacc or another stream on the device. Maybe we can go with this solution and do the background thing in the future. We can create another ticket for this, so we can't forget it :-) |
The first part works fine.
The issue may stay open for the 2nd part, see checkboxes I added above.
|
issue #93 allow volume control using hardware buttons
first part merged and will be integrated in the next upcoming release 4.1.0 |
Like here: https://www.reddit.com/media?url=https%3A%2F%2Fexternal-preview.redd.it%2F5lbgNSN6ShqzBT9m-F4wR5Dpia2Ab5tN9aX36fZ1EeQ.png%3Fauto%3Dwebp%26s%3Db19860dda13d91fbabcf213e55a64d7a100dc134
stages:
The text was updated successfully, but these errors were encountered: