Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: base url extraction in case its an object or string array #562

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Tomer-L
Copy link

@Tomer-L Tomer-L commented Mar 24, 2025

the problem is that buildRedirectURL function can receive baseUrl of type 'object' (returned from the function getSingleSignOnService)

The “url” argument must be of type string. Received an instance of Object

I ran into this issue myself when integrating with jumpcloud as IDP, after some online research I found out this solution
https://community.n8n.io/t/n8n-enterprise-sso-configuration-jumpcloud/65861/11
Beside of the support for object type I added support for the case that baseUrl is []string since the function getAssertionConsumerService may return it

Tested and it solved my problem.

discovered on jumpcloud sso integration
@Tomer-L Tomer-L changed the title fix: base url extraction in case its an object fix: base url extraction in case its an object or string array Mar 24, 2025
@Tomer-L
Copy link
Author

Tomer-L commented Mar 25, 2025

This might fix: #405 #308 #328
CC @tngan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant