fix: base url extraction in case its an object or string array #562
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the problem is that
buildRedirectURL
function can receivebaseUrl
of type 'object' (returned from the functiongetSingleSignOnService
)I ran into this issue myself when integrating with jumpcloud as IDP, after some online research I found out this solution
https://community.n8n.io/t/n8n-enterprise-sso-configuration-jumpcloud/65861/11
Beside of the support for
object
type I added support for the case thatbaseUrl
is[]string
since the functiongetAssertionConsumerService
may return itTested and it solved my problem.