Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental opensearch self query (self query retriever + query constructor) #487

Closed
wants to merge 21 commits into from

Conversation

t0mpl
Copy link
Contributor

@t0mpl t0mpl commented Jan 4, 2024

PR Checklist

  • Read the Contributing documentation.
  • Read the Code of conduct documentation.
  • Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
  • Describes the source of new concepts.
  • References existing implementations as appropriate.
  • Contains test coverage for new functions.
  • Passes all golangci-lint checks.

@tmc
Copy link
Owner

tmc commented Jan 7, 2024

@ThomasP1988 can you shore this up and mark it ready for review? (or are you seeking a review in the current draft state?)

@t0mpl
Copy link
Contributor Author

t0mpl commented Jan 7, 2024

unfortunately it's still far from being finished, this is a big piece of work but just sharing progress in case I take a wrong decision or something needs to be discussed

@t0mpl t0mpl marked this pull request as ready for review January 24, 2024 03:12
@t0mpl t0mpl closed this Jan 27, 2024
@tmc
Copy link
Owner

tmc commented Jan 27, 2024

@ThomasP1988 why close this?

@t0mpl
Copy link
Contributor Author

t0mpl commented Jan 27, 2024

I will open another one soon, but i'm adding a schema detector + an example for semi structured rag on opensearch, almost done but need some more work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants