Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLM: Add support for Ernie chat_completions #355

Merged
merged 14 commits into from
Nov 30, 2023
Merged

LLM: Add support for Ernie chat_completions #355

merged 14 commits into from
Nov 30, 2023

Conversation

sxk10812139
Copy link
Contributor

@sxk10812139 sxk10812139 commented Nov 15, 2023

The current implementation lacks support for Ernie chat_completions, so I've added code for this. The committed changes include basic stream calls, function calls, and other capabilities.

The invocation of Ernie is based on the official documentation at https://cloud.baidu.com/doc/WENXINWORKSHOP/s/jlil56u11.

For documentation on this content in the Python version of Langchain, please refer to https://python.langchain.com/docs/integrations/chat/ernie.

PR Checklist

  • Read the Contributing documentation.
  • Read the Code of conduct documentation.
  • Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
  • Describes the source of new concepts.
  • References existing implementations as appropriate.
  • Contains test coverage for new functions.
  • Passes all golangci-lint checks.

The current implementation lacks support for Ernie chat_completions, so I've added code for this. The committed changes include basic stream calls, function calls, and other capabilities.

The invocation of Ernie is based on the official documentation at https://cloud.baidu.com/doc/WENXINWORKSHOP/s/jlil56u11.

The current implementation lacks support for Ernie chat_completions, so I've added code for this. The committed changes include basic stream calls, function calls, and other capabilities.

The invocation of Ernie is based on the official documentation at https://cloud.baidu.com/doc/WENXINWORKSHOP/s/jlil56u11.

For documentation on this content in the Python version of Langchain, please refer to https://python.langchain.com/docs/integrations/chat/ernie.
@sxk10812139
Copy link
Contributor Author

Can this PR be merged? Our project will use this feature. Please help confirm. Thank you. @tmc

Copy link
Owner

@tmc tmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmc tmc merged commit 2567a2f into tmc:main Nov 30, 2023
tmc pushed a commit that referenced this pull request Dec 5, 2023
* LLM: Add support for Ernie chat_completions

The current implementation lacks support for Ernie chat_completions, so I've added code for this. The committed changes include basic stream calls, function calls, and other capabilities.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants