Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Weaviate Client creation use NewClient() over New() #1106

Closed
wants to merge 17 commits into from

Conversation

taigrr
Copy link
Contributor

@taigrr taigrr commented Jan 18, 2025

PR Checklist

  • Read the Contributing documentation.
  • Read the Code of conduct documentation.
  • Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
  • Describes the source of new concepts.
  • References existing implementations as appropriate.
  • Contains test coverage for new functions.
  • Passes all golangci-lint checks.

Fixes #1105 1105

ankit-arora and others added 17 commits October 24, 2024 17:19
merge in toolcall fix
@danielmerja
Copy link
Contributor

@taigrr this is a god send PR

@taigrr
Copy link
Contributor Author

taigrr commented Jan 18, 2025

Going to reopen this, my PR was from the main branch and I needed other features. Going to recreate from a featurebranch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong Client creation function used for Weaviate vectorstore
3 participants