You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the calculator tool (tools.Calculator) is located in the tools package, it depends on the third party go.starlark.net/starlark
Assumption
I assume this dependency is not meant to be brought into the dependency graph for all of the other tools since they depend on the tools package (due to them referencing the tools.Tool interface)
Question
Would it be reasonable to move the calculator functionality into its own package (tools/calculator/calculator.go)
The text was updated successfully, but these errors were encountered:
Background
Currently the calculator tool (
tools.Calculator
) is located in thetools
package, it depends on the third partygo.starlark.net/starlark
Assumption
I assume this dependency is not meant to be brought into the dependency graph for all of the other tools since they depend on the
tools
package (due to them referencing thetools.Tool
interface)Question
Would it be reasonable to move the calculator functionality into its own package (
tools/calculator/calculator.go
)The text was updated successfully, but these errors were encountered: