Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: Suggestion to move calculator tool into its own package #1119

Open
peterhellberg opened this issue Jan 30, 2025 · 0 comments
Open

tools: Suggestion to move calculator tool into its own package #1119

peterhellberg opened this issue Jan 30, 2025 · 0 comments

Comments

@peterhellberg
Copy link

Background

Currently the calculator tool (tools.Calculator) is located in the tools package, it depends on the third party go.starlark.net/starlark

Assumption

I assume this dependency is not meant to be brought into the dependency graph for all of the other tools since they depend on the tools package (due to them referencing the tools.Tool interface)

Question

Would it be reasonable to move the calculator functionality into its own package (tools/calculator/calculator.go)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant