From 98fa24d3e7d290f20111ba5fb44064bac41d69bb Mon Sep 17 00:00:00 2001
From: Jeremy <pattonjp@gmail.com>
Date: Thu, 30 Nov 2023 16:34:34 -0600
Subject: [PATCH] Simplify milvus example  (#383)

adding huggingface text embeddings interface as docker service for convienience
---
 .../README.md                                  | 18 +++++++++++++-----
 .../docker-compose.yml                         |  9 +++++++++
 .../milvus_vectorstore_example.go              |  7 -------
 3 files changed, 22 insertions(+), 12 deletions(-)

diff --git a/examples/huggingface-milvus-vectorstore-example/README.md b/examples/huggingface-milvus-vectorstore-example/README.md
index 3dca60799..d229217ad 100644
--- a/examples/huggingface-milvus-vectorstore-example/README.md
+++ b/examples/huggingface-milvus-vectorstore-example/README.md
@@ -1,13 +1,21 @@
 # Milvus vector store with local embeddings via huggingface TEI.
 
 Dependencies:
-- [Text Embeddings Inference](https://github.com/huggingface/text-embeddings-inference)
-- [Ollama](https://ollama.ai/) 
+- [Text Embeddings Inference](https://github.com/huggingface/text-embeddings-inference) (optional)
 
 ```shell
-# start milvus
+# start milvus and text embeddings interface
 docker-compose up -d
 
-#start embedding server
-text-embeddings-router --model-id thenlper/gte-large --port 5500
+
 ```
+
+## For faster embeddings
+
+```shell
+# stop txt-inference container
+docker compose stop txt-inference
+
+# start embedding server
+text-embeddings-router --model-id thenlper/gte-large --port 5500
+```
\ No newline at end of file
diff --git a/examples/huggingface-milvus-vectorstore-example/docker-compose.yml b/examples/huggingface-milvus-vectorstore-example/docker-compose.yml
index 522e038e9..fe1c15506 100644
--- a/examples/huggingface-milvus-vectorstore-example/docker-compose.yml
+++ b/examples/huggingface-milvus-vectorstore-example/docker-compose.yml
@@ -42,6 +42,15 @@ services:
       - "etcd"
       - "minio"
 
+  txt-inference:
+    platform: linux/x86_64
+    image: ghcr.io/huggingface/text-embeddings-inference:${TEI_TAG:-cpu-latest}
+    command: --model-id thenlper/gte-base
+    ports:
+      - 5500:80
+    volumes:
+      - ${DOCKER_VOLUME_DIRECTORY:-.}/volumes/txt-inference:/data
+
 networks:
   default:
     name: milvus
diff --git a/examples/huggingface-milvus-vectorstore-example/milvus_vectorstore_example.go b/examples/huggingface-milvus-vectorstore-example/milvus_vectorstore_example.go
index de966a336..f6f0a1560 100644
--- a/examples/huggingface-milvus-vectorstore-example/milvus_vectorstore_example.go
+++ b/examples/huggingface-milvus-vectorstore-example/milvus_vectorstore_example.go
@@ -22,7 +22,6 @@ func main() {
 		log.Fatalf("new: %v\n", err)
 	}
 	citiesExample(store)
-
 }
 
 func newEmbedder() (embeddings.Embedder, error) {
@@ -114,12 +113,6 @@ func citiesExample(store vectorstores.VectorStore) {
 			numDocuments: 100,
 			options: []vectorstores.Option{
 				vectorstores.WithScoreThreshold(.4),
-				// vectorstores.WithFilters(filter{
-				// 	"$and": []filter{
-				// 		{"area": filter{"$gte": 1000}},
-				// 		{"population": filter{"$gte": 13}},
-				// 	},
-				// }),
 			},
 		},
 	}