Retrieve latest headers and cookies #161
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xtsukino
requested changes
Apr 3, 2025
…r setting and retrieving cookies/headers
0xtsukino
requested changes
Apr 29, 2025
|
|
||
| await Promise.all([ | ||
| sublevel.put(name, value), | ||
| timestampSublevel.put(name, timestamp.toString()), |
There was a problem hiding this comment.
Almost there!
we do not care about timestamping each key, we only care about timestamp per URL.
Instead of timestamping here, you should time stamp whenever a request is intercepted. You can just add a method setTimestampForUrl above this line: https://github.com/tlsnotary/tlsn-extension/blob/main/src/entries/Background/handlers.ts#L22
| const headerLink = url | ||
| ? Object.keys(links).filter((l) => minimatch(l, link))[0] | ||
| const matchedLink = url | ||
| ? Object.keys(links).filter((l) => l === link || minimatch(l, link))[0] |
There was a problem hiding this comment.
instead of returning the first filtered result, return the MOST RECENT filtered result based on url timestamp
| const sublevel = db.sublevel(matchedLink); | ||
| const timestampSublevel = sublevel.sublevel('timestamp'); | ||
|
|
||
| for await (const [key, rawValue] of sublevel.iterator({ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.