Better reading of Int data types #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allows smaller multiple 8 channels to be read.
|
Noticed that some entries are missing after the reading - hold off on any potential merge until fixed. |
BleakerM
commented
Jan 30, 2025
|
Thanks, looks good! The failures on the nightlies seems unrelated. Do you mind adding some tests for the new features? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of issue #4 by allowing breaking down the iostream into UInt8 and then bit shifting this to represent the correct value as a UInt32, it also allows double floats (Float64) to be read in. The current fix passes all tests relevant to the changes. Tests not passed are the deprecation warnings for data and param fields.
The only thing this doesn't fix is for oddly sized ints e.g. Int10 - this would need a bit mask.