Test for FETCHCONTENT_BASE_DIR #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lambourl
force-pushed
the
feature/FETCHCONTENT_BASE_DIR_test
branch
2 times, most recently
from
0d6d1b2 to
2b10286
Compare
Lambourl
changed the title
daminetreg
changed the title
daminetreg
changed the title
23 tasks
daminetreg
requested changes
Jan 31, 2025
test/check_change_base.cpp
Outdated
| fs::exists((new_base_fetchcontent / "iconv-build" / "CMakeCache.txt")); | ||
| run_command(get_cmake_build_command(test_project_path, data), test_project_path); | ||
| fs::exists((new_base_fetchcontent / "mathlib-install" / "lib" / "libMathFunctions.a")); | ||
| fs::exists((new_base_fetchcontent / "Iconv-install" / "lib" / "libiconv.a")); |
There was a problem hiding this comment.
Hi @Lambourl,
Thanks for your contribution, however the test doesn't test anything, no BOOST_REQUIRE in there. The behaviour isn't tested.
There was a problem hiding this comment.
yes you are right i don't know why I forgot to use BOOST_REQUIRE, I have done the change
daminetreg
requested changes
Jan 31, 2025
cmake/modules/hfc_initialize.cmake
Outdated
| if (NOT DEFINED CACHE{HERMETIC_FETCHCONTENT_REMOVE_BUILD_DIR_AFTER_INSTALL}) | ||
| set(HERMETIC_FETCHCONTENT_REMOVE_SOURCE_DIR_AFTER_INSTALL OFF CACHE BOOL "By default save space by removing sources after install" FORCE) | ||
| if (NOT DEFINED CACHE{HERMETIC_FETCHCONTENT_REMOVE_SOURCE_DIR_AFTER_INSTALL}) | ||
| set(HERMETIC_FETCHCONTENT_REMOVE_SOURCE_DIR_AFTER_INSTALL OFF CACHE BOOL "By default keep install folder" FORCE) | ||
| endif() |
There was a problem hiding this comment.
Now that we switched to OFF by default we could actually likely remove completely both checks.
There was a problem hiding this comment.
This is lilkely the topic of another PR than this one :
- 1 PR for FETCHCONTENT_BASE_DIR test
- 1 PR for the typo fix of HERMETIC_FETCHCONTENT_REMOVE_SOURCE_DIR_AFTER_INSTALL
There was a problem hiding this comment.
#14 pr for : HERMETIC_FETCHCONTENT_REMOVE_SOURCE_DIR_AFTER_INSTALL
Lambourl
force-pushed
the
feature/FETCHCONTENT_BASE_DIR_test
branch
from
2b10286 to
941350c
Compare
Lambourl
changed the title
Automatic test to avoid regressions when user sets independently or combine FETCHCONTENT_BASE_DIR or HERMETIC_FETCHCONTENT_INSTALL_DIR. Change-Id: I0706eed78eeaaa861434ef1038d0bc011a31ad0d
daminetreg
force-pushed
the
feature/FETCHCONTENT_BASE_DIR_test
branch
from
941350c to
07c63bc
Compare
daminetreg
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
After @Lambourl removed the fix into a separate PR and after I extended the tests I approve the change is ready for release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test showing that you can move the build folder and install folder by forcing FETCHCONTENT_BASE_DIR .
Close : https://github.com/tipi-build/specs-cmake-re/issues/42