Controlling build parallelism level #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pysco68
changed the title
13 tasks
daminetreg
requested changes
Feb 14, 2025
| @@ -69,8 +69,7 @@ function(hfc_autotools_register_content_build content_name) | |||
| endif() | |||
| set (AUTOTOOLS_MAKE_PROGRAM "${MAKE_PROGRAM}") | |||
|
|
|||
| ProcessorCount(NUM_JOBS) | |||
| set (build_command "${MAKE_PROGRAM} -j ${NUM_JOBS}") | |||
| set (build_command "${MAKE_PROGRAM} -j @NUM_JOB_PLACEHOLDER@") # the @@ placeholder will be replaced in the generated external project | |||
There was a problem hiding this comment.
So this is a placeholder that will expand to a bash variable 🤔 , why use a placeholder at all ?
There was a problem hiding this comment.
didn't want the bash variable code to be duplicated accross autotools and cmake build and yet still be able to evaluate the cmake logic at the right time in any of the combinatorials of build time and configure time dependencies.
| - the value of the environment variable ``CMAKE_BUILD_PARALLEL_LEVEL`` | ||
| - the value supplied to ``cmake --build`` via the ``-j <jobs>`` / ``--parallel <jobs>`` argument | ||
|
|
||
| Generally not that dependencies that are made available at **build time** will have their own, separate |
| - during the build | ||
| - dependencies **made available at build time** will use 2 CPU cores | ||
| - the top level build graph (your project) will use 10 CPU cores | ||
|
|
There was a problem hiding this comment.
This section is very long for a simple option, I wonder if we really like to be that much detailed as we plan to change this in future versions.
pysco68
force-pushed
the
feature/concurrency-control
branch
from
4795d39 to
58811b2
Compare
daminetreg
reviewed
Feb 14, 2025
pysco68
force-pushed
the
feature/concurrency-control
branch
2 times, most recently
from
3d792f7 to
81fcd0c
Compare
CHANGELOG - Improved the way that build parallelism settings are forwarded through the build graph so that the correct outcome is achieved depending on setting CMAKE_BUILD_PARALLEL_LEVEL via environment Change-Id: I33ae3760b2a0ab00048f07ac2a7c14d3bbc460b7
pysco68
force-pushed
the
feature/concurrency-control
branch
from
81fcd0c to
6129a3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Change-Id: I33ae3760b2a0ab00048f07ac2a7c14d3bbc460b7