Restructure library to easily support adding a new scheme system variants #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamyGolden
force-pushed
the
jamy/feature/system-wrapping
branch
3 times, most recently
from
a0bde42 to
e8aba6c
Compare
- Pass `SchemeSystem` into Template creation to allow for different template builders to be built into tinted-builder-rust - Remove anyhow crate from tinted-builder lib and use custom Error enum with thiserror library
JamyGolden
force-pushed
the
jamy/feature/system-wrapping
branch
from
e8aba6c to
5d75163
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been playing around with the idea of adding a new scheme system to tinted-builder but it requires some refactoring to separate Base16 as the default/main system.
This change allows new scheme systems to be easily added without breaking the API.