Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy support for MapBox authorization #1560

Open
ansis opened this issue Jul 3, 2012 · 4 comments
Open

Proxy support for MapBox authorization #1560

ansis opened this issue Jul 3, 2012 · 4 comments

Comments

@ansis
Copy link
Contributor

ansis commented Jul 3, 2012

The browser TileMill is running in needs to be aware of the proxy in order for authorization to work.

The real fix would be to pass it as an option to topcube, and get topcube to set an environment variable within that process. The browser should pick up on it. Should be fairly simple to do.

If we don't get around to fixing it, we should add a dialog informing the user of the workaround (running TileMill in a browser to authorize their account) when they try to authorize.

@springmeyer
Copy link
Member

@Aibram - from the sounds of this ticket the only actionable thing for 0.10 might be to add a warning?

@ansis
Copy link
Contributor Author

ansis commented Jul 11, 2012

Yeah, I'll add a warning and a link to authorize in a browser.

@ansis
Copy link
Contributor Author

ansis commented Jul 11, 2012

Opened upstream ticket at creationix/topcube#16

@ansis
Copy link
Contributor Author

ansis commented Jul 11, 2012

Revert 2f2dc84 when properly fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants