Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: prevent ping from forwarding #9042

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

*: prevent ping from forwarding #9042

wants to merge 2 commits into from

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Feb 7, 2025

What problem does this PR solve?

Issue Number: Close #9031.

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 7, 2025
@rleungx rleungx force-pushed the ping branch 2 times, most recently from dc8c88d to ab75292 Compare February 7, 2025 09:01
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 7, 2025
@rleungx rleungx requested a review from JmPotato February 8, 2025 04:12
@rleungx
Copy link
Member Author

rleungx commented Feb 8, 2025

/retest

Copy link
Contributor

ti-chi-bot bot commented Feb 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, lhy1024

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 8, 2025
Copy link
Contributor

ti-chi-bot bot commented Feb 8, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-07 11:39:13.692357647 +0000 UTC m=+10996.088579708: ☑️ agreed by lhy1024.
  • 2025-02-08 04:13:59.317844002 +0000 UTC m=+70681.714066063: ☑️ agreed by JmPotato.

@rleungx
Copy link
Member Author

rleungx commented Feb 8, 2025

/retest

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.21%. Comparing base (d9abd06) to head (b55c82b).
Report is 1432 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9042      +/-   ##
==========================================
+ Coverage   75.65%   76.21%   +0.55%     
==========================================
  Files         332      467     +135     
  Lines       33902    71156   +37254     
==========================================
+ Hits        25650    54232   +28582     
- Misses       6056    13532    +7476     
- Partials     2196     3392    +1196     
Flag Coverage Δ
unittests 76.21% <100.00%> (+0.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

ti-chi-bot bot commented Feb 10, 2025

@rleungx: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-integration-realcluster-test b55c82b link true /test pull-integration-realcluster-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/needs-triage-completed lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ping request should not be forwarded
3 participants