Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: make TestScatterRegion stable #9040

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Feb 6, 2025

What problem does this PR solve?

Issue Number: Close #7109

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. labels Feb 6, 2025
Copy link
Contributor

ti-chi-bot bot commented Feb 6, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lhy1024, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 6, 2025
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.21%. Comparing base (dcb426b) to head (315a604).
Report is 1428 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9040      +/-   ##
==========================================
+ Coverage   75.54%   76.21%   +0.66%     
==========================================
  Files         332      467     +135     
  Lines       33892    71113   +37221     
==========================================
+ Hits        25604    54197   +28593     
- Misses       6082    13524    +7442     
- Partials     2206     3392    +1186     
Flag Coverage Δ
unittests 76.21% <ø> (+0.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@okJiang okJiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why this modification makes the test stable? Thanks~

@lhy1024
Copy link
Contributor Author

lhy1024 commented Feb 8, 2025

Can you explain why this modification makes the test stable? Thanks~

After clientTestSuite.SetupTest add ResetRegionCache, the test became unstable

I added some logs and found there is no region in region tree when scatter.

So I retry region heartbeat and scatter when meet error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestScatterRegions is unstable
2 participants