Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(traffic_light): enable to calculate correct distance from ego to traffic light #74

Merged
merged 2 commits into from
Dec 27, 2024

Conversation

MasatoSaeki
Copy link
Contributor

@MasatoSaeki MasatoSaeki commented Dec 26, 2024

Types of PR

  • New Features
  • Upgrade of existing features
  • Bugfix

Description

This PR enables to calculate correct distance from ego to traffic light.
[background]
Evaluator node calculate from ego to first traffic light(I mean first index) which is belong to regulatory element until now. If its traffic light is not minimum distance in regulatory element from ego, autoware can not be filterd by evaluator node's distance correctly.

How to review this PR

I have checked it on Evaluator.
There was intersection which is not calculated correctly, but I confirmed this PR enables to do correctly.

Others

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
@MasatoSaeki MasatoSaeki marked this pull request as ready for review December 26, 2024 13:10
Copy link
Collaborator

@hayato-m126 hayato-m126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM

@hayato-m126 hayato-m126 merged commit d4f08aa into develop Dec 27, 2024
8 checks passed
@hayato-m126 hayato-m126 deleted the fix/culculate_correct_distance branch December 27, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants