Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SHEL-1310] Update No Seating Chart Copy and Graphic #256

Merged
merged 10 commits into from
Jan 16, 2024
Merged

Conversation

bsl782
Copy link
Contributor

@bsl782 bsl782 commented Jan 16, 2024

Jira: SHEL-1310

Why / What

This PR adds the missing seatmap icon and centers the icon and text.

Testing

I tested this code manually.

Reviewer Checklist (To be edited and marked by approver)

After approving the PR, the reviewer should check the boxes below. See the Reviewer Checklist company standard for more info on these bullet points.

  • Do you understand the reasoning behind the need for the changes?
  • Given only new or existing tests*, do you feel confident that all changes work as intended and solve the problem at hand?
  • Are all success and failure paths accounted for in the tests? If not, are the omissions explained/justified?
  • If coverage ignores are present, is justification provided inline (or linked to) or is a link to a ticket to address in the future provided?
  • Are you willing to accept the same responsibility for this code as the author?

*If existing tests, requester should point out what applies

PR Code Coverage

  • Changeset: XX%
  • Overall: XX%

Measure with bin/test_cov or some other means. You can find html coverage levels in coverage/index.html or in stdout.

After a successful test run, you can also see calculated and merged coverage, per branch, on Grafana

@bsl782 bsl782 self-assigned this Jan 16, 2024
bsl782 and others added 3 commits January 17, 2024 00:42
Co-authored-by: tevo-nikita-ivashkov <134063908+tevo-nikita-ivashkov@users.noreply.github.com>
Copy link
Contributor

@tevo-nikita-ivashkov tevo-nikita-ivashkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bsl782 bsl782 merged commit c255500 into master Jan 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants