Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEAT-291, SEAT-292: removed unfetch, switched to inline svg #248

Merged
merged 5 commits into from
Jan 8, 2024

Conversation

tevo-nikita-ivashkov
Copy link
Contributor

@tevo-nikita-ivashkov tevo-nikita-ivashkov commented Jan 8, 2024

Jira: SEAT-291

Why / What

This PR replaces unfetch with fetch-ponyfill.
This PR disables UMD standalone build as current build setup breaks with fetch-ponyfill.

This PR also fixes icons for SEAT-292 as svg tools were one of potentials causes for build fails.

Testing

I tested this code by running test suit and manually checking build files.

Reviewer Checklist (To be edited and marked by approver)

After approving the PR, the reviewer should check the boxes below. See the Reviewer Checklist company standard for more info on these bullet points.

  • Do you understand the reasoning behind the need for the changes?
  • Given only new or existing tests*, do you feel confident that all changes work as intended and solve the problem at hand?
  • Are all success and failure paths accounted for in the tests? If not, are the omissions explained/justified?
  • If coverage ignores are present, is justification provided inline (or linked to) or is a link to a ticket to address in the future provided?
  • Are you willing to accept the same responsibility for this code as the author?

*If existing tests, requester should point out what applies

PR Code Coverage

  • Changeset: XX%
  • Overall: XX%

Measure with bin/test_cov or some other means. You can find html coverage levels in coverage/index.html or in stdout.

After a successful test run, you can also see calculated and merged coverage, per branch, on Grafana

@tevo-nikita-ivashkov tevo-nikita-ivashkov requested a review from a team January 8, 2024 09:20
@tevo-nikita-ivashkov
Copy link
Contributor Author

Created a separate ticket to readd umd builds
https://ticketevolution.atlassian.net/browse/SEAT-293

@tevo-nikita-ivashkov tevo-nikita-ivashkov merged commit 0609174 into master Jan 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants