From 2e3d208899723f746cc7f0874548ceb8ad9824a2 Mon Sep 17 00:00:00 2001 From: harmantevo <166038179+harmantevo@users.noreply.github.com> Date: Fri, 11 Oct 2024 18:01:49 +0530 Subject: [PATCH] Shel 1858 added linting (#294) * added changes for testing * added example and changesets too * added package json too * added changeset file * updated package json * added changes as per the comments * added changes as per the comments * updated html file script * made changes as per the comments * fix package json issues * fix folder name * fix folder name * added changes to include dist folder in build * remove unused depedencies * updated pnpm yaml * just for testing * fixed linting issue * Created changeset for build * changfed var to let * added fix for the vite config --- .changeset/gentle-pianos-whisper.md | 5 ++ examples/vite-build-standalone/index.html | 72 +++++++++++-------- examples/vite-build-standalone/package.json | 1 + examples/vite-build-standalone/vite.config.js | 4 ++ packages/seatmaps-client/.eslintignore | 3 +- packages/seatmaps-client/src/index.tsx | 15 ---- packages/seatmaps-client/vite.config.ts | 10 +-- pnpm-lock.yaml | 5 +- 8 files changed, 64 insertions(+), 51 deletions(-) create mode 100644 .changeset/gentle-pianos-whisper.md create mode 100644 examples/vite-build-standalone/vite.config.js diff --git a/.changeset/gentle-pianos-whisper.md b/.changeset/gentle-pianos-whisper.md new file mode 100644 index 0000000..654dc8e --- /dev/null +++ b/.changeset/gentle-pianos-whisper.md @@ -0,0 +1,5 @@ +--- +"@ticketevolution/seatmaps-client": minor +--- + +updated files for to improve build ptrocess diff --git a/examples/vite-build-standalone/index.html b/examples/vite-build-standalone/index.html index 2c573e9..ef681a8 100644 --- a/examples/vite-build-standalone/index.html +++ b/examples/vite-build-standalone/index.html @@ -1,31 +1,45 @@ - - - - - - - - -
- - + + - + // Create a new instance of SeatmapFactory + const factory = new Tevomaps.SeatmapFactory(options); + + // Ensure the element exists before calling the build method + const rootElementId = "map"; + if (document.getElementById(rootElementId)) { + factory.build(rootElementId); + } else { + console.error(`Element with id '${rootElementId}' not found.`); + } + }); + }; + + diff --git a/examples/vite-build-standalone/package.json b/examples/vite-build-standalone/package.json index dcef517..f9403a2 100644 --- a/examples/vite-build-standalone/package.json +++ b/examples/vite-build-standalone/package.json @@ -5,6 +5,7 @@ "run-example": "pnpm serve ." }, "dependencies": { + "@-/mock-data": "workspace:*", "@ticketevolution/seatmaps-client": "workspace:*", "serve": "^14.2.3" }, diff --git a/examples/vite-build-standalone/vite.config.js b/examples/vite-build-standalone/vite.config.js new file mode 100644 index 0000000..522c244 --- /dev/null +++ b/examples/vite-build-standalone/vite.config.js @@ -0,0 +1,4 @@ +/** @type {import('vite').UserConfig} */ +export default { + publicDir: "./" +} \ No newline at end of file diff --git a/packages/seatmaps-client/.eslintignore b/packages/seatmaps-client/.eslintignore index 82867da..488c7b6 100644 --- a/packages/seatmaps-client/.eslintignore +++ b/packages/seatmaps-client/.eslintignore @@ -2,4 +2,5 @@ stats cjs esm umd -node_modules \ No newline at end of file +node_modules +bundle.js \ No newline at end of file diff --git a/packages/seatmaps-client/src/index.tsx b/packages/seatmaps-client/src/index.tsx index 26deb8e..7990c4e 100644 --- a/packages/seatmaps-client/src/index.tsx +++ b/packages/seatmaps-client/src/index.tsx @@ -75,18 +75,3 @@ export class SeatmapFactory { } export { TicketMap }; - -export const Tevomaps = SeatmapFactory; -declare var define: any; - -(function (root, factory) { - if (typeof define === "function" && define.amd) { - define([], factory); - } else if (typeof module === "object" && module.exports) { - module.exports = factory(); - } else { - (root as any).Tevomaps = factory(); - } -})(typeof self !== "undefined" ? self : this, function () { - return SeatmapFactory; -}); diff --git a/packages/seatmaps-client/vite.config.ts b/packages/seatmaps-client/vite.config.ts index 0b422d2..4a110b0 100644 --- a/packages/seatmaps-client/vite.config.ts +++ b/packages/seatmaps-client/vite.config.ts @@ -7,10 +7,10 @@ export default defineConfig({ plugins: [react()], build: { lib: { - entry: resolve("src/index.tsx"), - name: "Tevomaps", - fileName: () => `bundle.js`, - formats: ["umd"], + entry: resolve("src/index.tsx"), // Entry point to your main file + name: "Tevomaps", // Global variable name + fileName: () => `bundle.js`, // Output file name + formats: ["umd"], // UMD format to make it globally available }, rollupOptions: { external: [], @@ -22,7 +22,7 @@ export default defineConfig({ }, plugins: [ inject({ - process: "process/browser", + process: "process/browser", // Polyfill 'process' for browser environments }), ], }, diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 12575e6..23f7418 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -143,6 +143,9 @@ importers: examples/vite-build-standalone: dependencies: + '@-/mock-data': + specifier: workspace:* + version: link:../../internal/mock-data '@ticketevolution/seatmaps-client': specifier: workspace:* version: link:../../packages/seatmaps-client @@ -5297,7 +5300,7 @@ packages: resolution: {integrity: sha512-oWb1Z6mkHIskLzEJ/XWX0srkpkTQ7vaopMQkyaEIoq0fmtFVxOthb8cCxeT+p3ynTdkk/RZwbgG4brR5BeWECw==} engines: {node: '>= 4.0'} os: [darwin] - deprecated: The v1 package contains DANGEROUS / INSECURE binaries. Upgrade to safe fsevents v2 + deprecated: Upgrade to fsevents v2 to mitigate potential security issues requiresBuild: true dependencies: bindings: 1.5.0