Shel 1858 added linting (#294)

* added changes for testing * added example and changesets too * added package json too * added changeset file * updated package json * added changes as per the comments * added changes as per the comments * updated html file script * made changes as per the comments * fix package json issues * fix folder name * fix folder name * added changes to include dist folder in build * remove unused depedencies * updated pnpm yaml * just for testing * fixed linting issue * Created changeset for build * changfed var to let * added fix for the vite config
ticketevolution · Oct 11, 2024 · 2e3d208 · 2e3d208
1 parent fb4a8d1
commit 2e3d208
Show file tree

Hide file tree

Showing 8 changed files with 64 additions and 51 deletions.
diff --git a/.changeset/gentle-pianos-whisper.md b/.changeset/gentle-pianos-whisper.md
@@ -0,0 +1,5 @@
+---
+"@ticketevolution/seatmaps-client": minor
+---
+
+updated files for to improve build ptrocess
diff --git a/examples/vite-build-standalone/index.html b/examples/vite-build-standalone/index.html
@@ -1,31 +1,45 @@
-<!DOCTYPE HTML>
-<html>
-<head>
-  <meta charset="UTF-8">
-  <link rel="icon" href="data:,">
-  <link href="https://fonts.googleapis.com/css?family=Open+Sans:400,700" rel="stylesheet">
-</head>
-<body style="margin: 0;">
-  <div id="map" style="height: 100vh; width: 100vw;"></div>
-  <script src="node_modules/@ticketevolution/seatmaps-client/dist/bundle.js"></script>
-  <script>
-    window.onload = function() {
-      const data = {
-        "ticketGroups": [
-          {
-            "tevo_section_name": "upper end zone 232",
-            "retail_price": 100
-          }
-        ]
-      };
+<!doctype html>
+<html lang="en">
+  <head>
+    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
+    <meta charset="UTF-8" />
+    <link rel="icon" href="data:," />
+    <link
+      href="https://fonts.googleapis.com/css?family=Open+Sans:400,700"
+      rel="stylesheet"
+    />
+    <title>Seatmap Example</title>
+  </head>
+  <body>
+    <!-- Ensure this element has the correct id -->
+    <div id="map"></div>
+
+    <script src="node_modules/@ticketevolution/seatmaps-client/dist/bundle.js"></script>
+    <!-- UMD build bundle -->
+    <script>
+      window.onload = function () {
+        fetch("./node_modules/@-/mock-data/data/ticket-groups-1591449.json")
+          .then((response) => response.json())
+          .then((data) => {
+            const options = {
+              venueId: "896",
+              configurationId: "14341",
+              mapFontFamily: '"Open Sans", sans-serif',
+              ticketGroups: data,
+            };
 
-      window.seatmapsInstance = new window.Tevomaps({
-        venueId: '896',
-        configurationId: '14341',
-        mapFontFamily: '"Open Sans", sans-serif',
-        ticketGroups: data.ticketGroups
-      }).build('map');
-    }
-  </script>
-</body>
+            // Create a new instance of SeatmapFactory
+            const factory = new Tevomaps.SeatmapFactory(options);
+
+            // Ensure the element exists before calling the build method
+            const rootElementId = "map";
+            if (document.getElementById(rootElementId)) {
+              factory.build(rootElementId);
+            } else {
+              console.error(`Element with id '${rootElementId}' not found.`);
+            }
+          });
+      };
+    </script>
+  </body>
 </html>
diff --git a/examples/vite-build-standalone/package.json b/examples/vite-build-standalone/package.json
@@ -5,6 +5,7 @@
     "run-example": "pnpm serve ."
   },
   "dependencies": {
+    "@-/mock-data": "workspace:*",
     "@ticketevolution/seatmaps-client": "workspace:*",
     "serve": "^14.2.3"
   },

diff --git a/examples/vite-build-standalone/vite.config.js b/examples/vite-build-standalone/vite.config.js
@@ -0,0 +1,4 @@
+/** @type {import('vite').UserConfig} */
+export default {
+  publicDir: "./"
+}
diff --git a/packages/seatmaps-client/.eslintignore b/packages/seatmaps-client/.eslintignore
@@ -2,4 +2,5 @@ stats
 cjs
 esm
 umd
-node_modules
+node_modules
+bundle.js 
diff --git a/packages/seatmaps-client/src/index.tsx b/packages/seatmaps-client/src/index.tsx
@@ -75,18 +75,3 @@ export class SeatmapFactory {
 }
 
 export { TicketMap };
-
-export const Tevomaps = SeatmapFactory;
-declare var define: any;
-
-(function (root, factory) {
-  if (typeof define === "function" && define.amd) {
-    define([], factory);
-  } else if (typeof module === "object" && module.exports) {
-    module.exports = factory();
-  } else {
-    (root as any).Tevomaps = factory();
-  }
-})(typeof self !== "undefined" ? self : this, function () {
-  return SeatmapFactory;
-});
diff --git a/packages/seatmaps-client/vite.config.ts b/packages/seatmaps-client/vite.config.ts
@@ -7,10 +7,10 @@ export default defineConfig({
   plugins: [react()],
   build: {
     lib: {
-      entry: resolve("src/index.tsx"),
-      name: "Tevomaps",
-      fileName: () => `bundle.js`,
-      formats: ["umd"],
+      entry: resolve("src/index.tsx"), // Entry point to your main file
+      name: "Tevomaps", // Global variable name
+      fileName: () => `bundle.js`, // Output file name
+      formats: ["umd"], // UMD format to make it globally available
     },
     rollupOptions: {
       external: [],
@@ -22,7 +22,7 @@ export default defineConfig({
       },
       plugins: [
         inject({
-          process: "process/browser",
+          process: "process/browser", // Polyfill 'process' for browser environments
         }),
       ],
     },

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml