Improvement/metadata on jsonapi render #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any hold up on this change. It would be very useful! |
npendery
reviewed
Apr 10, 2020
| @@ -186,6 +186,8 @@ def turn_into_resource(record, options) | |||
| # @api private | |||
| def result_options(records, options) | |||
| {}.tap do |data| | |||
| data[:meta] = options.fetch(:meta, {}) | |||
There was a problem hiding this comment.
Not sure if data[:meta] has record counts already, but id maybe merge the two instead of assigning
There was a problem hiding this comment.
Suggested change
| data[:meta] = options.fetch(:meta, {}) | |
| data[:meta] = data.fetch(:meta, {}).merge(options.fetch(:meta, {})) |
|
@tiagopog could we add this? It would be very useful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is no way to pass top-level
metaobjects in the current implementation as it only filters for pagination options, record_count and page_count.This line allows to
jsonapi_renderto include top-level meta information in the following way: