Skip to content

Commit

Permalink
chore: Updates to improve test flakiness (excaliburjs#2246)
Browse files Browse the repository at this point in the history
This PR is doing some work to attempt to improve test flakiness from it's various sources

BrowserStack
ImageDiff
  • Loading branch information
eonarheim authored Feb 12, 2022
1 parent 91d0b4f commit 01a7479
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 4 deletions.
2 changes: 1 addition & 1 deletion appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ init:
# What combinations to test
environment:
matrix:
- nodejs_version: '14'
- nodejs_version: '16'
platform:
- x64
install:
Expand Down
6 changes: 5 additions & 1 deletion karma.conf.browsers.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ module.exports = (config) => {
browserStack: {
project: 'Excalibur',
username: process.env.BS_USERNAME,
accessKey: process.env.BS_PASSWORD
accessKey: process.env.BS_PASSWORD,
timeout: 600
},
singleRun: true,
frameworks: ['jasmine'],
Expand Down Expand Up @@ -103,7 +104,10 @@ module.exports = (config) => {
// Show a list of test clients, 'always', 'never' or 'ifneeded'
browserList: 'always'
},
browserDisconnectTimeout : 10000,
browserDisconnectTolerance : 1,
browserNoActivityTimeout: 60000, // appveyor is slow :(
captureTimeout : 4*60*1000,
// define browsers
customLaunchers: {
bs_latest_chrome_win10: {
Expand Down
2 changes: 1 addition & 1 deletion src/spec/DebugTextSpec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,6 @@ describe('DebugText', () => {

ctx.flush();

await expectAsync(flushWebGLCanvasTo2D(canvasElement)).toEqualImage('src/spec/images/DebugTextSpec/draw-webgl.png');
await expectAsync(flushWebGLCanvasTo2D(canvasElement)).toEqualImage('src/spec/images/DebugTextSpec/draw-webgl.png', .94);
});
});
3 changes: 2 additions & 1 deletion src/spec/ExcaliburGraphicsContextSpec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,8 @@ describe('The ExcaliburGraphicsContext', () => {
expect(imageRenderer.flush).toHaveBeenCalledTimes(1);

await expectAsync(flushWebGLCanvasTo2D(canvasElement)).toEqualImage(
'src/spec/images/ExcaliburGraphicsContextSpec/painter-order-circle-image-rect.png'
'src/spec/images/ExcaliburGraphicsContextSpec/painter-order-circle-image-rect.png',
.95
);
});

Expand Down

0 comments on commit 01a7479

Please sign in to comment.