From 0a02c867b4cfe0094bcdb054753c8c722c36727e Mon Sep 17 00:00:00 2001 From: Peter Boling Date: Tue, 25 Feb 2025 01:54:44 +0700 Subject: [PATCH] =?UTF-8?q?=F0=9F=92=9A=20Pend=20spec=20failure?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Possibly due to bundler issue on MRI and JRuby engines - https://github.com/rubygems/rubygems/issues/8518 --- appraisal.gemspec | 1 + spec/acceptance/bundle_without_spec.rb | 5 ++++- spec/spec_helper.rb | 1 + 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/appraisal.gemspec b/appraisal.gemspec index 67da5627..533b12e0 100644 --- a/appraisal.gemspec +++ b/appraisal.gemspec @@ -49,4 +49,5 @@ Gem::Specification.new do |s| s.add_development_dependency("activesupport", ">= 3.2.21") s.add_development_dependency("rspec", "~> 3.13") + s.add_development_dependency("rspec-pending_for", "~> 0.1", ">= 0.1.17") end diff --git a/spec/acceptance/bundle_without_spec.rb b/spec/acceptance/bundle_without_spec.rb index 4194071e..b454adf1 100644 --- a/spec/acceptance/bundle_without_spec.rb +++ b/spec/acceptance/bundle_without_spec.rb @@ -2,7 +2,10 @@ RSpec.describe "Bundle without group" do it "config set --local without group is honored by Bundler" do - # pending "config set --local without group support seems broken, see: https://github.com/rubygems/rubygems/issues/8518" + reason = "config set --local without group support seems broken, see: https://github.com/rubygems/rubygems/issues/8518" + # Somehow this spec passes on truffleruby *only*!! + pending_for(:engine => "ruby", :reason => reason) + pending_for(:engine => "jruby", :reason => reason) build_gems %w[pancake orange_juice waffle coffee sausage soda] build_gemfile <<-GEMFILE.strip_heredoc.rstrip diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index 8eb8a448..1d9f7366 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -16,6 +16,7 @@ # External Libraries require "active_support/core_ext/string/strip" +require "rspec/pending_for" # This library require "support/dependency_helpers"