Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

Add quality selection for kimcartoon #36

Open
kittybitme opened this issue Feb 13, 2020 · 2 comments
Open

Add quality selection for kimcartoon #36

kittybitme opened this issue Feb 13, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@kittybitme
Copy link

Description
Regardless of the settings, extracting links from any given server (either from the "Extract links" button or the "Grab" button next to each individual episode) will result in the 720p link being returned.

Information

  1. Browser: macOS Chrome Version 80.0.3987.100
  2. Userscript Manager: Tampermonkey
  3. Show, Episode: Craig of the Creek S2, any/all episodes
  4. Server: Any

Additional information
I tried digging into the userscript a bit to see what was wrong, but I couldn't pinpoint anything specific.

@kittybitme kittybitme added the bug Something isn't working label Feb 13, 2020
@thorio thorio added enhancement New feature or request and removed bug Something isn't working labels Feb 13, 2020
@thorio
Copy link
Owner

thorio commented Feb 13, 2020

This is because the default grabber (which is used for kimcartoon) doesn't actually support quality selection. It just takes whatever it can get, which is usually 720p since it's selected by default.
I have updated the wiki page to make this more apparent.

I personally rarely, if ever, use this script for sites other than kissanime, so i don't really want to spend the time to implement this. If you want to take a shot at it yourself though, the relevant code is here.

@thorio thorio changed the title Only grabs 720p download links on Kimcartoon.to Add quality selection for kimcartoon Feb 13, 2020
@kittybitme
Copy link
Author

Thanks for the info! I'll take a look at the relevant block and see if I can't suss something out.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants