Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate Logging Event IDs (e.g. 10103) #493

Open
thomashilzendegen opened this issue Feb 24, 2025 · 3 comments
Open

Duplicate Logging Event IDs (e.g. 10103) #493

thomashilzendegen opened this issue Feb 24, 2025 · 3 comments
Labels

Comments

@thomashilzendegen
Copy link
Collaborator

We need to consolidate them in a central lib to prevent this

@thomashilzendegen thomashilzendegen added bug and removed bug labels Feb 24, 2025
@gingters
Copy link
Member

Are they within the same log category?
Otherwise it should be fine, as log event ids only need to be unique within their corresponding category.
See also: https://learn.microsoft.com/en-us/dotnet/core/compatibility/aspnet-core/7.0/microsoft-aspnetcore-mvc-core-log-event-ids

Oh, and the ASP.NET Core Team thinks that this is a breaking change as it affects binary compatibility.
That would need to major version upgrade then.

@thomashilzendegen
Copy link
Collaborator Author

No, but I got a warning from code generation about that:

Image

@gingters
Copy link
Member

Oh. Well.. then... we should fix that ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants