New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve onChange callback performance #7

Open

haivle wants to merge 1 commit into thinhkhang97:master from haivle:fix-bugs

haivle commented Apr 17, 2024 •

edited

Loading

Only call onChange callback when inViewport value changed
Fix the issue with incorrect measures on Android
Add onChange to useEffect dependency to allow the callback function to update its scope

Example

const [count, setCount] = useState(1);

useEffect(() => {
   setCount(2)
},[])

const handleViewPortChange = (isInViewport: boolean) => {
    console.log(count) // --> issue: always return 1
}

<ViewPortDetector onChange={handleViewPortChange}>
  {//...children}
</ViewPortDetector>


          fix: improve onChange callback performance

f20a707

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet