Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup & refactor faketime use #265

Merged
merged 6 commits into from
Feb 11, 2025
Merged

Cleanup & refactor faketime use #265

merged 6 commits into from
Feb 11, 2025

Conversation

jku
Copy link
Member

@jku jku commented Feb 9, 2025 •
edited
Loading

I wanted to add sigstore root-signing repository as test data in the test suite but ended up doing this cleanup PR first.

  • Move the "test infra" code into a sub directory: this should make it clearer what the actual tests are
  • refactor faketime setup
    • Use an actual datetime for the reference time argument (instead of "days in future")
    • add a "timestamp" file to static test repositories: a date when the repository is known to be valid. This will be useful because by using this time with faketime, we will be able to add real world repos with short expiry times (see Add sigstore root-signing as static test data #264)
    • Add a test to verify that our faketime setup works
    • Add a workaround in the golang client to make it actually use faketime (Go does not use libc so bypasses faketime without this)

jku added 4 commits February 9, 2025 10:50
@jku
Refactor: Move all infra code to subdir
a0a2650 
This way the main tuf_conformance/ directory contains just tests.

Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
@jku
Refactor: Use datetime as argument when faking time
9e4a8c8 
"days_in_future" is not really usable in cases where we want to test a
specific date (whereas the relative time is easy to transform to a
datetime.)

Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
@jku
Static tests: Add refresh time for static tests
26298a9 
This will allow adding real world repositories that have short
expiries

Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
@jku
Add test to verify that faketime actually works
26ec5f4 
It does not work with golang.

Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
@jku jku mentioned this pull request Feb 9, 2025
Merged
@jku jku marked this pull request as ready for review February 9, 2025 11:04
@jku
go test client: Jump through hoops to get current time
2672ea4 
* test suite uses faketime to set client reference time: this works for
  most clients
* Golang does not use libc so bypasses the tricks that faketime uses:
  faketime does not work for go client
* Add dumb code in the test client to get the current date with "date"
  command: this does use libc so is handled by faketime
* This fixes test_faketime(): remove expected failure

Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
@jku jku mentioned this pull request Feb 9, 2025
Closed
@jku jku linked an issue Feb 10, 2025 that may be closed by this pull request
go client is not fooled by faketime #263
Closed
@jku jku requested review from loosebazooka and a team February 11, 2025 10:00
@jku
static data: Improve readme
a275180 
Remove requirement to be a long lived repo

Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
@jku jku merged commit 1efa2da into theupdateframework:main Feb 11, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdimitrov rdimitrov rdimitrov approved these changes

@loosebazooka loosebazooka Awaiting requested review from loosebazooka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

go client is not fooled by faketime
2 participants
@jku @rdimitrov