updater.go: replace os.WriteFile with file.Write() (#669)

* Update updater.go

replace os.WriteFile with file.Write()

Signed-off-by: udf2457 <udf2457@users.noreply.github.com>

* Update metadata/updater/updater.go

File is closed on all branches in the code, removing this.

Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>

---------

Signed-off-by: udf2457 <udf2457@users.noreply.github.com>
Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
Co-authored-by: Fredrik Skogman <kommendorkapten@github.com>

metadata/updater/updater.go

@@ -596,11 +596,22 @@ func (update *Updater) persistMetadata(roleName string, data []byte) error {
 	if err != nil {
 		return err
 	}
-	defer file.Close()
+	// change the file permissions to our desired permissions
+	err = file.Chmod(0644)
+	if err != nil {
+		// close and delete the temporary file if there was an error while writing
+		file.Close()
+		errRemove := os.Remove(file.Name())
+		if errRemove != nil {
+			log.Info("Failed to delete temporary file", "name", file.Name())
+		}
+		return err
+	}
 	// write the data content to the temporary file
-	err = os.WriteFile(file.Name(), data, 0644)
+	_, err = file.Write(data)
 	if err != nil {
-		// delete the temporary file if there was an error while writing
+		// close and delete the temporary file if there was an error while writing
+		file.Close()
 		errRemove := os.Remove(file.Name())
 		if errRemove != nil {
 			log.Info("Failed to delete temporary file", "name", file.Name())