ASRC: move to DRAM #9844
Merged
ASRC: move to DRAM #9844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark non-performance critical code with the __cold attribute. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
memory.h is required for __cold and __cold_rodata, add it. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
jsarha
approved these changes
Feb 19, 2025
| @@ -533,7 +560,7 @@ static enum asrc_error_code initialise_filter(struct comp_dev *dev, | |||
| /* Reset coefficients for possible exit with error. */ | |||
| src_obj->filter_length = 0; | |||
| src_obj->num_filters = 0; | |||
| src_obj->polyphase_filters = NULL; | |||
There was a problem hiding this comment.
Looks like this was never needed for anything else but to potentially find bugs where the filter is accessed uninitialized. For that purpose it could still be valid there.
There was a problem hiding this comment.
@jsarha it is now inside the asrc_free_polyphase_filter() function and I think it can be needed when called from asrc_set_fs_ratio()
lgirdwood
approved these changes
Feb 19, 2025
|
because of #9845 I cannot run-time test this, so perhaps it's better to not merge it before it's been tested |
|
Waiting for thesofproject/linux#5335 to be merged |
lyakh
requested review from
a team,
singalsu,
abonislawski,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
dbaluta
reviewed
Feb 26, 2025
| @@ -321,6 +321,7 @@ static int asrc_free(struct processing_module *mod) | |||
|
|
|||
| rfree(cd->buf); | |||
| asrc_release_buffers(cd->asrc_obj); | |||
There was a problem hiding this comment.
can you explain why is this needed? Is sram much smaller?
singalsu
approved these changes
Feb 26, 2025
|
@lyakh can you check CI, looks like valgrind has picked up something in testbench test. |
Free SRAM by moving ASRC coefficients to DRAM and only copying the single required array on demand. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
|
CI:
|
lgirdwood
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move ASRC filter coefficients and some DRC functions to DRAM