ipc4: mixin: Improve HiFi3 mix with gain impl #9810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clearing of AE_VALIGN registers with AE_ZALIGN64() is only necessary when they are used for memory write operations. There is no need to do this for registers used for memory read. Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>
Simpler and faster implementation of HiFi3 mix with gain functions. The previous version works fine. This is just an improvement to make the code faster and more straightforward. Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>
serhiy-katsyuba-intel
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
serhiy-katsyuba-intel
requested review from
singalsu,
abonislawski and
softwarecki
softwarecki
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simpler and faster implementation of HiFi3 mix with gain functions. The previous version works fine. This is just an improvement to make the code faster and more straightforward.