Move log and system_service headers to module directory #9335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
softwarecki
requested review from
lgirdwood,
tobonex,
abonislawski,
kv2019i,
marcinszkudlinski,
jxstelter,
tmleman,
serhiy-katsyuba-intel and
gbernatxintel
softwarecki
requested review from
plbossart,
mmaka1,
lbetlej and
dbaluta
as code owners
lgirdwood
approved these changes
Aug 5, 2024
Comment on lines
+17
to
+21
| #ifdef __XTENSA__ | ||
| #define RESTRICT __restrict | ||
| #else | ||
| #define RESTRICT | ||
| #endif |
There was a problem hiding this comment.
It may be best to comment why this cant come from Zephyr as I suspect Zephyr will define this too.
There was a problem hiding this comment.
ping - this needs a comment at least so that no one tries to optimize this later on.
There was a problem hiding this comment.
@lgirdwood
Indeed zephyr has a similar definition ZRESTRICT, but we want to be able to build lmdk modules without using zephyr headers so I didn't use it.
kv2019i
approved these changes
Aug 5, 2024
|
@softwarecki can you rebase? |
tmleman
approved these changes
Aug 7, 2024
|
@softwarecki probably worth rebasing on Monday as CI doing upgrade today 9th Aug. |
Move logging priority definitions used by iadk modules to the modules directory so other types of loadable modules can use them. Propose a function to convert log priority used by loadable modules to log level used by sof. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
Move definitions of functions exposed by system_service to the modules directory so that loadable modules can use them. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
softwarecki
force-pushed
the
modules-sp2
branch
from
85ca085 to
db28a6e
Compare
lgirdwood
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move logging priority definitions used by iadk modules to the modules directory so other types of loadable modules can use them. Propose a function to convert log priority used by loadable modules to log level used by sof.
Move definitions of functions exposed by system_service to the modules directory so that loadable modules can use them.