-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
topology2: pcm_caps: Remove defaults for rate_min/rate_max #9017
Conversation
Use 'rates' instead to specify that 48K is the default supported rate. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests failing on all platforms:
https://sof-ci.01.org/sofpr/PR9017/build3818/devicetest/index.html
and no dmesg |
Something is wrong with CI, in the failing cases it tries to use 0Hz rate: resulting |
The reason is that the sof-test is parsing the topology and uses rate_min, rate_max which is now 0 if it is not set explicitly. The same issue with #9004 (converted back to draft). |
vs
The PCM itself shows correct information:
|
that's a spectacular dependency on sof-test parsing of topology. Oh well. Glad it was caught, our CI results just improved over the last week, probably not wise to run CI into the ground again... |
@ujfalusi yes softest relies on rate min/max. I have a fix coming soon |
@ujfalusi any update ? |
SOFCI TEST |
After thesofproject/sof-test#1174 merged, I re-triggered the device test. It looks good so far. |
Another problem with this: |
Use 'rates' instead to specify that 48K is the default supported rate.