[TEST] zephyr cache API change 68140 + SMP restore revert 68366 #8824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses arch_cpu_start() instead of arch_start_cpu() as it has been renamed to align with the CPU namespace. Signed-off-by: Daniel Leung <daniel.leung@intel.com> (cherry picked from commit b22ce6d)
This changes the seconday core power up routine to use the newly introduced k_smp_cpu_start() and k_smp_cpu_resume(). This removes the need to mirror part of the SMP start up code from Zephyr, and no longer need to call into Zephyr private kernel code. Signed-off-by: Daniel Leung <daniel.leung@intel.com> (cherry picked from commit 11c251a)
Use system cache API instead of soc specific calls. Signed-off-by: Anas Nashif <anas.nashif@intel.com> (cherry picked from commit 0606152)
marc-hb
changed the title
marc-hb
force-pushed
the
test-zephyr-cache-68140
branch
from
7984437 to
98d036f
Compare
marc-hb
changed the title
marc-hb
changed the title
|
sparse fails like this: |
|
SOFCI TEST |
marc-hb
commented
Jan 31, 2024
west.yml
Outdated
| # DNM: testing cache API change | ||
| # https://github.com/zephyrproject-rtos/zephyr/pull/68140 | ||
| # + revert / fix 68366 | ||
| revision: 5a9866b1f7bc08f8aa7eb4cec4cf46ddf91448ba |
There was a problem hiding this comment.
marc-hb
force-pushed
the
test-zephyr-cache-68140
branch
from
98d036f to
1cd6dbe
Compare
|
Simpler "CODEC" configurations are fine. NOCODEC configurations also failing in https://sof-ci.01.org/sofpr/PR8824/build2490/devicetest/index.html?model=TGLU_RVP_NOCODEC-ipc4&testcase=check-playback-3times, same looking panic. |
|
The pattern of HW tests that failed is very similar to the results of this other, slightly different test PR: However this one has a panic backtrace, the other one has not. The other one does not have the cache API change. It has other fixes. |
Test Zephyr cache API 68140 + pick SMP revert 68366 Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
force-pushed
the
test-zephyr-cache-68140
branch
from
1cd6dbe to
42d39f1
Compare
marc-hb
commented
Feb 1, 2024
There was a problem hiding this comment.
Much fewer sparse warnings with new commit 42d39f1 but still quite a few:
https://github.com/thesofproject/sof/actions/runs/7733940349/job/21086994035?pr=8824
...
include/zephyr/cache.h:511:16: warning: incorrect type in return expression (different address spaces)
include/zephyr/cache.h:511:16: warning: incorrect type in return expression (different address spaces)
include/zephyr/cache.h:511:16: warning: incorrect type in return expression (different address spaces)
include/zephyr/cache.h:511:16: warning: incorrect type in return expression (different address spaces)
include/zephyr/cache.h:511:16: warning: incorrect type in return expression (different address spaces)
include/zephyr/cache.h:535:16: warning: incorrect type in argument 1 (different address spaces)
soc/xtensa/intel_adsp/common/boot_complete.c:25:43: warning: incorrect type in argument 1 (different address spaces)
include/zephyr/cache.h:535:16: warning: incorrect type in argument 1 (different address spaces)
subsys/debug/coredump/coredump_backend_intel_adsp_mem_window.c:27:9: warning: incorrect type in argument 1 (different address spaces)
subsys/debug/coredump/coredump_backend_intel_adsp_mem_window.c:48:55: warning: incorrect type in argument 1 (different address spaces)
subsys/debug/coredump/coredump_backend_intel_adsp_mem_window.c:49:48: warning: incorrect type in argument 1 (different address spaces)
include/zephyr/cache.h:535:16: warning: incorrect type in argument 1 (different address spaces)
include/zephyr/cache.h:535:16: warning: incorrect type in argument 1 (different address spaces)
include/zephyr/cache.h:535:16: warning: incorrect type in argument 1 (different address spaces)
drivers/console/winstream_console.c:81:45: warning: incorrect type in argument 1 (different address spaces)
include/zephyr/cache.h:535:16: warning: incorrect type in argument 1 (different address spaces)
...
| # DNM: testing cache API change | ||
| # https://github.com/zephyrproject-rtos/zephyr/pull/68140 | ||
| # + revert / fix 68366 | ||
| revision: 5daaa64245d6b226efd2ef2571c409a689a958e2 |
There was a problem hiding this comment.
Closed
|
Similar panics with newer commit 42d39f1 in CAVS https://sof-ci.01.org/sofpr/PR8824/build2497/devicetest/index.html and ACE https://sof-ci.01.org/sofpr/PR8824/build2496/devicetest/index.html. This time one soundwire configuration paniced too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing combination of