Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sof-dump-status.py: add ADL-N PCI DID #976

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

kv2019i
Copy link
Contributor

@kv2019i kv2019i commented Oct 28, 2022

Add PCI DID for ADL-N.

Signed-off-by: Kai Vehmanen kai.vehmanen@linux.intel.com

Add PCI DID for ADL-N.

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
@kv2019i kv2019i requested a review from a team as a code owner October 28, 2022 19:37
Copy link
Collaborator

@marc-hb marc-hb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ADL-N found in https://github.com/thesofproject/linux/blob/topic/sof-dev/sound/soc/sof/intel/pci-tgl.c as expected.

@kv2019i, @plbossart does this mean there will be new sof-adl-n.ri binaries in /lib/firmware/sof different from both sof-adl.ri and sof-adl-s.ri and everything else? Different even for community or just a key difference?

As a coincidence here's a good, recent picture of symbolic links in /lib/firmware:

thesofproject/sof-bin@df24de4

@aiChaoSONG
Copy link

aiChaoSONG commented Oct 31, 2022

@marc-hb Check Pierre's patch in the kernel thesofproject/linux#3920, adl-n uses a different signing key, that means it will have its own production signed firmware, but for community signed, I think we can make a symbol link to adl firmware.

@marc-hb
Copy link
Collaborator

marc-hb commented Nov 3, 2022

This patch adds a new PCI-ID while #973 stops using PCI-ID. How come?

@marc-hb
Copy link
Collaborator

marc-hb commented Nov 3, 2022

While CI is still having problems this is zero risk, merging.

@marc-hb marc-hb merged commit 9714158 into thesofproject:main Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants